+ 1
do i need to re fork in order to submit new pull request?
recently i contributed to github in order to do that i forked the original repo &then did a pull request it is still pending. Now i want to submit new features to do this should i simply push codes to my original fork which i have used earlier for first pull request and then do a pull request or delete this original fork & re fork it I m worried about that as my 1st modification is still pending&if i push my new codes to the fork which contains those changes new pull request will also shown in new pull req?
2 Antworten
+ 1
You dont neex to refork. Generally I found the most convenient way to work is to start a dedicated branch for your pull request. Later you can keep pulling the original master branch and write a new pull request by branching to a different new branch from the current master, and then submit the new pull request.
But much more important:
Did you get any comments on your original pull request?
Do you know WHY it wasnt accepted?
I think you should figure this out before submitting another pull request.
You can post the link to your pull request here.
+ 1
yes i got several comments but it requires 2 approval from those who have write permission. As of now my code is accepted by one person only. i checked and found that it usually takes some days and i have submitted codes recently.