[Solved] No Numerals

Question

I tried to solve this question:

Task:
Take a phrase and replace any instances of an integer from 0-10 and replace it with the English word that corresponds to that integer.

Sample Input:
i need 2 pumpkins and 3 apples

Sample Output:
i need two pumpkins and three apples

This is my code:

original_text = input().lower()
arr = ["zero","one","two","three","four","five","six","seven","eight","nine","ten"]
lst = original_text.split(" ")
for i in lst:
try:
if i.isdigit() & int(i) <= 10:
original_text = original_text.replace(i,arr[int(i)])
except:
pass

print(original_text)

It worked for test cases 1,2,3 and 6
But it failed in test cases 4 and 5.
I don't know what is the problem and if I could write a better code.
Thank you for your help.

Answer 1

Simba You're right.
My code was right at the beginning just needed to delete the lower() method.
I put that because in the description explicitly said that do the lower case I think.
By the way thank you all guys for participating. ❤❤❤

Answer 2

I believe you didn't try this yet

original_text = input()

Answer 3

Hello Siavash Kardar Tehran

Your code is not working for this case:
0 cats and 10 dogs

output: zero cats and 1zero dogs

Answer 4

Brian I don't think that's the case, because both
issigit() and <= return True or False.

Answer 5

rodwynnejones using replace in this way has the problem that it does not discriminate what it replaces. "2nd" becomes "twond". "1000" becomes "tenzerozero". You should replace word by word rather than the whole line at once.

Answer 6

Korkunç TheTerrible because there are some test cases have uppercase letters.
For example,
Cat 10 should return Cat ten not cat ten

Answer 7

https://www.sololearn.com/Discuss/2998467/?ref=app

Answer 8

i would do it this way:

arr = {
'0': 'zero',
'1': 'one',
'2': 'two',
'3': 'three',
'4': 'four',
'5': 'five',
'6': 'six',
'7': 'seven',
'8': 'eight',
'9': 'nine',
'10': 'ten'
}

original_text = input().lower().split()
new_text = []

for i in original_text:
if i in arr.keys():
new_text.append(arr[i])
else:
new_text.append(i)

print(' '.join(new_text))

Answer 9

The problem I see right away is that you are mistakenly using bitwise & in the test for single-digit numbers. It will fail for even numbers because their bit0 will be zero. Try changing to logical and.

Edit: On closer inspection I see that the fix won't solve all the problems. I think 0 and 10 will yet fail.

Answer 10

Siavash Kardar Tehran I realized that the if statement makes no difference in this code. Really it is the exception handling that makes it work. With or without the if statement, it works the same!

The reason it failed the tests is that the replace function replaces all occurrances. So it would replace a 1 as one, and also replace a later occurrance of 100 as one00.

Here is my fix:

original_text = input() #.lower()
arr = ["zero","one","two","three","four","five","six","seven","eight","nine","ten"]
lst = original_text.split(" ")
for i in range(len(lst)):
try:
lst[i] = arr[int(lst[i])]
except:
pass

print(' '.join(lst))

Edit: One more tweak is needed to pass the Code Coach tests. Remove the conversion of the input into lowercase.

Answer 11

I agree...for the code you wrote...You used string.split()...I didn't, I used string.replace() method.

Answer 12

mydict = {
"10": "ten",
"9": "nine",
"8": "eight",
"7": "seven",
"6": "six",
"5": "five",
"4": "four",
"3": "three",
"2": "two",
"1": "one",
"0": "zero"
}

# user input not used, just a simple string to test 1, 0, and 10
# are correctly replaced.
mystring = "i need 1 pumpkins and 10 apples 0 oranges"

for x in mydict.keys():
mystring = mystring.replace(x, mydict[x])

print(mystring)

Answer 13

Ah, ok, I hadn't considered that, thank you.

Answer 14

@Simba Oh. Darn. lol. Thank you :-)

Answer 15

Murodilla Karimov When I input:
Hello 2.

It fails to do the number before the dot.
How to solve this?

Answer 16

Any punctuation after numbers fails.
Should I use regex?

Answer 17

Siavash Kardar Tehran you are right about that. Even numbers in the bitwise & evaluate to 0, which is <=10. Now I am puzzled. I will look further.

Answer 18

Try this:

import re

arr = {
'0': 'zero',
'1': 'one',
'2': 'two',
'3': 'three',
'4': 'four',
'5': 'five',
'6': 'six',
'7': 'seven',
'8': 'eight',
'9': 'nine',
'10': 'ten'
}

original_text = input()
pattern_num = r'[0-9]+' # include all numbers

for i in original_text.split():
for n in re.findall(pattern_num, i): # this option for extracting all numbers from text. returns list object
if n in arr.keys():
original_text = original_text.replace(n, arr[n])

print(original_text)

Answer 19

I don't recall, do the test cases include punctuation at the end of the sentences?

Answer 20

I dont recall either