Help me correct the logical error

Question

I was trying different insertion operations
In the code attached below, I have a problem in the insorder function,
Size of array
5
My sample input:
88 56 4 2 5
Choice is 3
Element to add : 106
Output: 106 2 4 5 56 88
In actual output we expect 106 to be added at the last position but here it gets inserted as the first position.
If I choose choice 3 in the second program iteration the code works fine. I don't understand why. Please help, sorry for the long code and the inconvenience with the infinite loop.
SUMMARY: the element is not getting inserted at the end of the array instead gets added in the beginning.
NOTE: Since I have added an infinite loop please try the code in some other compiler.

https://sololearn.com/compiler-playground/c6lIrrdd2aDJ/?ref=app

Answer 1

try replacing your insorder with this

void insorder(int *a,int *n,int e)
{
for(int i=0;i<(*n-1);i++)
{
for(int j=0;j<(*n-i-1);j++)
{
if (a[j]>a[j+1])
{
int temp=a[j];
a[j]=a[j+1];
a[j+1]=temp;
}
}
}
int p;
if(e > a[*n]) p = *n;
else{
for (int i=0;i<(*n-1);i++)
{
if(e >= a[i] && e < a[i+1])
p=i;
}
}

inspos(a,n,p,e);
}

Answer 2

Bob_Li thank you for guiding me 😊

Answer 3

Bob_Li this introduced me to some new concepts , I'll get back to you with some doubts after my research on it😅(only if it doesn't bother you)

Answer 4

Bob_Li the given task requires me to sort first and then insert by order

Answer 5

Bob_Li 'key' with reference to my code was simply to allow user to insert an element after the element they wanted to

Answer 6

Note that the while loop does not work well in Sololearn's codebit input method. So testing your code here is not easy.

Your ordered insert looks unnecessarily complicated.
Why not insert first, sort later?

Answer 7

Here is your code that I modified for Sololearn.

I used the insert before sort method, and factored out the print array function from inspos.

This way, inspos does not need to be the last function called just because of the print array part is stuck to it.

It simplifies the code because you don't have to solve for the correct position in insorder.

Also, what is key in an array? An array have index and value, key is a hash table concept.

https://sololearn.com/compiler-playground/cJsJXLJI8wkO/?ref=app

Answer 8

Sanjana
It is more appropriate to call it 'value'

Although not the same as your code, here are some array functions I experimented with after viewing your code.

The realloc usage is not ideal, though. Generally, it is better to avoid frequent reallocations for better performance.

https://sololearn.com/compiler-playground/cNKSzPpMQ5Ed/?ref=app