0

Code review

Looking for positive and honest feedback on my code. I just finished my first start to finish code project and now I want to know how to get better. https://code.sololearn.com/WU7FqsQQ98Q5/?ref=app https://code.sololearn.com/WU7FqsQQ98Q5/?ref=app

21st Aug 2019, 7:22 PM
Kyle Mcclure
Kyle Mcclure - avatar
10 Answers
+ 2
If I'm being honest, you need much more improvements, very little css code, and you haven't used javascript at all.
21st Aug 2019, 7:31 PM
Aymane Boukrouh
Aymane Boukrouh - avatar
+ 2
Nice work! The only thing I would criticize in a code review is that your HTML indentation is a bit messy, which makes it harder to read.
21st Aug 2019, 7:57 PM
Schindlabua
Schindlabua - avatar
+ 2
Schindlabua thanks! I'll try to work on that indentation. I'm feeling like I want to start Jscript but honestly I want to get better with css too. What do you think?
21st Aug 2019, 7:59 PM
Kyle Mcclure
Kyle Mcclure - avatar
+ 1
You just need to learn abit more of css and javascript ;)
21st Aug 2019, 7:54 PM
Aymane Boukrouh
Aymane Boukrouh - avatar
+ 1
Actually I had no problem reading your html code, it was clear
21st Aug 2019, 7:58 PM
Aymane Boukrouh
Aymane Boukrouh - avatar
+ 1
Actually css you don't even need to learn it, just keep a reference near you, what you need to learn and undersand is javascript
21st Aug 2019, 8:00 PM
Aymane Boukrouh
Aymane Boukrouh - avatar
+ 1
Kyle Mcclure In my opinion learning HTML/CSS/JS at the same time is perfectly fine. You'll never know *all* there is to know about either language anyway.
21st Aug 2019, 8:02 PM
Schindlabua
Schindlabua - avatar
+ 1
Makes sense, I'll keep going through my tutorials and building projects and learning. I just wanted to see if I could build anything at all lol.
21st Aug 2019, 8:06 PM
Kyle Mcclure
Kyle Mcclure - avatar
0
Yeah I know but I was only using html and css but I know my css skills need much work. Could you give me some pointers? What would you do different?
21st Aug 2019, 7:50 PM
Kyle Mcclure
Kyle Mcclure - avatar
0
That's the right approach. :P
21st Aug 2019, 8:07 PM
Schindlabua
Schindlabua - avatar