Arrangement of Numbers

Question

I am a beginner of C++ program, and today is my second day of learning. There is a question in my assignment which said"please arrange and output four random numbers from smallest to biggest. And four numbers are between 0 and 10^10." Actually I design a program which is able to meet the request, but when I uploaded to the other test system, it told me it's a wrong answer. I wanna know if my program is incorrect or there are some conditions I've never consider.
MY PROGRAM : https://code.sololearn.com/cwuLl33pqrdA/#cpp

THANK YOU FOR YOUR HELP!!!!

Answer 1

int can store max 2^32. If input is 10^10, then size of int variable is not sufficient...!!!

Normally, 1st check test systems do is range check - . i. e. How SW behaves when minimum and maximum values are given. In your case it is 0 and 10^10.

Hope this helps...!!!

Answer 2

Your code does not work properly because you have a misunderstand in logical operators

if(a>b&&c&&d) it will not compare a with b then with c then with d
it will compare just with b then take the result and c and d

you did mean if(a>b&&a>c&&a>d)

in C++ every non zero value is true and just 0 is false so
consider the following example in your comparison and mine
a=4,b=3,c=2,d=6
if(a>b&&c&&d)
in values
if(4>3&&2&&6)
if(1&&non zero)
if(1)
so it is true although a is smaller than d

if(4>3&&4>2&&4>6)
if(1&&1&&0)
if(0)
it is false and works properly

Answer 3

Hi..
Modified some syntax in condition by putting additional brackets.
Variable type changed from int to long long int.
Check if your test system passes now.
Same problem can be realized in more efficient way...
https://code.sololearn.com/cRGAoPl6dVXd/?ref=app

Hope this helps...!!!

Answer 4

Really appreciate for both of your passionate helps. Unfortunately, I am still not pass it although my codes are proper and correct. I'll keep looking for where the points are. THANK YOU~~~