My code do not run correctly but I could not figure out a mistake in my code. Is there something that I am missing?

Question

var contacts = [
{
"firstName": "Akira",
"lastName": "Laine",
"number": "0543236543",
"likes": ["Pizza", "Coding", "Brownie Points"]
},
{
"firstName": "Harry",
"lastName": "Potter",
"number": "0994372684",
"likes": ["Hogwarts", "Magic", "Hagrid"]
},
{
"firstName": "Sherlock",
"lastName": "Holmes",
"number": "0487345643",
"likes": ["Intriguing Cases", "Violin"]
},
{
"firstName": "Kristian",
"lastName": "Vos",
"number": "unknown",
"likes": ["Javascript", "Gaming", "Foxes"]
}
];

function lookUpProfile(firstName, prop){

for (i = 0; i < contacts.length; i++) {

if (firstName === contacts[i].firstName) {

if (contacts[i].hasOwnProperty(prop)) {

return contacts[i].prop;

} else {

return "No such property";
}

} else {
return "No such contact";
}

}

}

lookUpProfile("Harry", "likes");

Answer 1

Your mistake is in your last 'else' statement (from the first 'if', as the second is nested): you are in a loop to verif if each item is equal to the searched value, but if it's not the first item you return the error message so exit from loop and doesn't continue testing other items ^^

@Calvin solution doesn't work as expected, and return 'undefined' value in case of contact not found... rather do:

function lookUpProfile(firstName, prop){

for (i = 0; i < contacts.length; i++) {

if (firstName === contacts[i].firstName) {

if (contacts[i].hasOwnProperty(prop)) {
return contacts[i][prop];
} else {
return "No such property";
}

}
return "No such contact";
}

... so the error message is returned only after all items were tested, and none found (else value will have been already returned breaking the loop)

Answer 2

https://code.sololearn.com/WtIL3CcLUO3O/?ref=app

Answer 3

I have understood, thank you all!! 😅😅