Please point problems in this code

Question

I'm creating a c++ program to find electronic configuration of atoms with atomic number. In output, I'm expecting z=2 and nat=10, but it is not outputting as my expectation. I request you to point mistakes in this code . Thank you in advance.

https://code.sololearn.com/c4f0CQZfYp2G/?ref=app

Answer 1

line no.25, 27
conditions of for loop are wrong
it should be z<=5 and y<=z

Answer 2

It worked. Thank you