Problem creating classes in cpp

Question

I was following the c++ tutorial step by step, and I created, in separated files, the MyClass that takes two integer arguments.
And I had the idea to make a similar one, but one taking strings for arguments.

Here is the header:

#ifndef PENDORCHO_H
#define PENDORCHO_H

class Pendorcho
{
public:
Pendorcho (string x);
void setName(string x);
string getName();

protected:

private:
const string name;
};

#endif // PENDORCHO_H

And here is the source:

#include "Pendorcho.h"
#include <iostream>
using namespace std;

Pendorcho::Pendorcho (string x)
: name(x)
{
cout << "Merenguete" << "\n";
}

Pendorcho::setName(string x)
{
name = x;
}

Pendorcho::getName()
{
return name;
}

This is my main:

int main()
{

Pendorcho obj1("Mingo");
obj1.getName();
obj1.setName("Mariela");
obj1.getName();
return 0;
}

When I try to run it I get this error in the header file:
Line 8: error: expected ')' before 'x'.

I don't know why I should close de parenthesis before the x, but I tried it and has no better result.

What am I doing wrong?

Answer 1

You need to:
#include <string>

Answer 2

the member data (name) is declared constantly and is initielized 2 times by the member functions ,

Answer 3

You don't have a:
using namespace std;
in your header so must use std::string to reference it.

Answer 4

Your Pendorcho.cpp has a few issues:
- It should include <string> (convention states you always include things you require even when they are included by your other includes),
- Pendorcho::setName is missing the function type of void, and
- Pendorcho::getName is missing the function type of string.

Answer 5

One last point, it is not a good idea putting using namespace in a header. You should either just use the symbols you must have or tag them with their namespace at each usage.
using string;
OR
Pendorcho (std::string x);

Answer 6

I wouldn't. Put three files into playground so I can see them. Post a link to all three.

Answer 7

You are very welcome. Enjoy your experimenting. Feel free to ask more here or as a comment on my code, if you need more help.

Answer 8

It should be in the h file immediately after the #define.

Answer 9

Thanks! Now it works nice

Thanks for being there!!

Answer 10

I'm sorry, it's not really clear where the error pop up.

Is the line in the header, the "Pendorcho (string x);" one

Answer 11

I've just tried with the #include <string> and I keep receiving the same error message.

I reduced my main function to this one:

int main()
{

Pendorcho man("Mingo");
man.getName();
return 0;
}

To avoid problems, and the name data is not a constant variable anymore.

Answer 12

There it is. I tryed removing it and puting it again with no better results.

Could be something wrong in my project configuration or something like that?

Maybe I should try starting it over from zero.

Answer 13

Let's see...

Main
https://code.sololearn.com/c0PkJ0tO2Xlw

Header
https://code.sololearn.com/c5Tn2Z55Ls8G

Source
https://code.sololearn.com/csv0wcX9yAQ3

Answer 14

First of all: thanks for the patience!

It did work and the compiler doesn't got stucked at that point.

But now I have an error in the class source.
Is in the line: "Pendorcho::setName(string x)"

And says:
error: prototype for 'std::__cxx11::string Pendorcho::setName(std::__cxx11::string)' does not match any in class 'Pendorcho'