How to make this code faster (reading text file then splitting it part by part at a charater and then output it --in java--

Question

https://code.sololearn.com/cmv18GLGrl6V/?ref=app

Answer 1

Call str.split outside the loop, store the result and use it anytime that you need it. Actually you call it 3 times at iteration, while one time (totally) is enough.
Anyway, you can:
- Read the input file size
- Create a preallocated buffer string of file size
- Copy input file content in this buffer
- Process this buffer like you doing

Answer 2

I searched on Internet, I didnt find an answer to me (my english is not so good), so I tried my code above

Answer 3

I'm pretty sure bufferreader are more faster than scanner.
But considering the file size sometimes scanner is more than enough, i mean probably there's only few ms difference in small files.

Answer 4

the file is just 6Mb, and the process is so slow, when I try with a 100Kb file, everything is perfect

Answer 5

Well maybe you cam try buffer reader

And bit of suggestion, put file writer outside the loop because it'll keep creating a new one each itteration.
Instead save all of the data in string, then write them to file after the code finish reading.

Answer 6

That makes me spin, how to put file writer outside the loop, there will be many files that should be created so how to create them?!

Answer 7

I mean the writer instance not the file, dont worry.

Instead of doing that create a StringBuffer before reading the file. Then just append() the text you want to write later on to it.

Once the reading done, you can start initialize your file writer then write the content in StringBuffer to a file