How to improve that code?

Question

Hi there,
I'm pretty new to python. While taking the course I'm trying to write small scripts for a better understanding of the theorie. What I see is, if my code works or not, but I don't know nearly nothing about it's performance. For example I know that tuples are faster than lists, but that's it with my knowledge so far.

Could anybody give me a feedback about this little code: https://code.sololearn.com/cvRkSIn8mrhy ? At which points could the code be improved, e.g. with other methods/functions? What is too complicated and could be written more compact?
I hope that will show me some ways to improve my further coding.

Thanks a lot!

Answer 1

inp = str((input("input some letters: \n")))

=> str() not needed, input() is str anyway

~~

a = []

for x in inp:
a.append(x)

=> can be replaced with

a = list(inp)

~~

def words(perms):
result = ""
for y in perms:
result += y
print(result)
return

=> can be replaced with

def words(perms):
result = ''.join(perms)
print(result)

Answer 2

In addition to everything Anna said, I hope it's okay if I add that you don't need to make the list "a" of characters from inp. You can directly feed it to permutations().

from itertools import permutations

inp = input("input some letters: \n")
inp = inp.replace(" ", "").lower()

for z in permutations(inp):
print(''.join(z))

Answer 3

Sure! If you have a list of strings, you can use the join method to combine them to a single string. It works like this:

l = ['a', 'b', 'c'] # sample list
print(''.join(l)) # output: abc

Just include the symbol you want to combine the single elements with in the quotation marks:

print('+'.join(l)) # output: a+b+c
print(', '.join(l)) # output: a, b, c

Answer 4

Katze war gerade zum ersten Mal im Schnee dieses Jahr :)

Answer 5

Kein Problem. Streichel deine Katze mal von mir 😻

Answer 6

Thanks for that hint, Kishalaya Saha!
I don't know intertools very good yet, cause its introduction in the python course was very short.

Answer 7

Thank you, Anna!
Filling a list this way will save me a lot of time in the future.
Could you explain me this part in detail: result = ''.join(perms) ?
What is the '' for? Does it mean "empty", like "" and then .join iterates every item in (perm) an appends it to result = ''?

Answer 8

Oh right... I slightly remember that lesson now. I think my brain needs an improvement, too :D