What is broken in my "security" code?

Question

The code is here:
https://code.sololearn.com/cLhEvyg9kIY1/?ref=app

It gets test 1 and 3 right, but doesn't get the same result with the rest. I suspect it reads Thur guard before it actually is, but by looking at it I can't notice why.

Answer 1

I found the problem. You see, even if the code had not gone through a single letter of the 'new_floor' string, it would enter the if/else statements to check if there was a alarm. A ELSE STATEMENT. That meant that even at the beginning, it would just drop at the print('quiet').

I fixed it using elif instead of else:
elif (thief == 1 and guard == 1 and money == 0) or (thief == 0 and guard == 1 and money == 1):
print('quiet')

Because of the natural iteration of 'for', it would never see money and a thief and a guard before my elif catches it.

It worked on 1 and 3 (even with the else structure) because these had "quiet" as an answer.

Anyways, Alexandr code is much more concise.

Answer 2

med gazzeh your solution is great, but I like Alexandr 's better

Answer 3

Oh, nice that works too :)

Answer 4

I jusst find "G" betwen "quot; and "T", and it solved all test.
python:
s=input()
m=s.find("quot;)
t=s.find("T")
g=s.find("G")
if (m>g and g>t) or (m<g and g<t):
print("quiet")
else:
print("ALARM")

Answer 5

Alexandr , unfortunately I don't get it

Answer 6

Alexandr now I get it!! However, could you provide me with problem in my code?

Answer 7

Alexandr shouldn't the native 'for' iteration check it (because it is always from left to right)?

Answer 8

Alexandr Yes, because when it removes a 'G', the next one becomes the 0, so by reading always from 1 it should jump a single 'G', if there is one.

Answer 9

Alexandr , I am glad you provided me a better way to program it, put I want to know where is the error so that I can learn from it.

Answer 10

On the second line whats the use of that empty string

Answer 11

CHIDERA AHAMEFULE the replace method requires to change something to another. So I replaced every 'x' with a empty space, therefore leaving only G, T or $

Answer 12

I think it would be better if you simply get rid of 'x' chars ( as you already did) and then just check the difference between the indexes of '#x27; and 'T'.
For exemple : 'xxGxxGxxTxxx$xxG' gives 'GGT$G' thus | index('T') - index('#x27;) | = 1 thus the alarm should be raised, otherwise not.

Answer 13

I can't find alexandr solution in comments can you plz post it below so I can check it?

Answer 14

med gazzeh ugh, looks like he removed it, sorry. After you got rid of 'x's, Alexandr suggested checking if there was a "$T" or "Tquot;, because these would be the only "ALARM" possibilities. If there wasn't, then the code would print 'quiet'.

Answer 15

Hello