How could i improve the code for the binarysearch?

Question

https://code.sololearn.com/cStd88De16JM/?ref=app

Answer 1

It would be more readable if you used proper indenting and a function, so I recommend you start with that.

Drop the erase, it wrecks the purpose of a binary search. Instead use vars to keep track of front, mid and back.

Add support for numbers that do not exist.

After you get that implemented your next improvement could be the use of templates so you're not restricted to just ints.

Lastly drop the using namespace std; for a more professional look.

Answer 2

thanks a lot! i will work on that