I wrote this code in c to convert normal time to military time is there anything i can do to make it simpler ? please help me

Question

https://code.sololearn.com/c93sUqUTW0Xo/?ref=app

Answer 1

12:30 AM outputs 0:30 should be 00:30

Answer 2

Yeah I fixed it 😅 ,...anything else sir?

Answer 3

I Fixed that sir😁 👍thank you, ... Can i make it any simpler 😅?

Answer 4

Ok i will give it a try but it's 3:00 am over here in India ,.. so i guess I will do it after I wake up 😊 thanks for answering sir

Answer 5

The code coach input for this challenge will gives the same format consistently. Where there aren't any leading zeros and there is always a space between AM or PM which are always capitalized. I'm sure you could reduce your code by using built in functions etc, but that's up to you. I would however suggest avoiding the use of goto. Instead put that code in a function and call it.

Answer 6

Ok sir thank you very much for the advice 😊😊

Answer 7

Check this code i think it works(i checked several variants) and it is a little bit smaller then yours))))
https://code.sololearn.com/cKJHCiv4vSzG/?ref=app

Answer 8

https://code.sololearn.com/c9wa4CZXUC0F/?ref=app

You may try checking this out.

Answer 9

I've done it without including <string.h>. You can check this out 🙃
https://code.sololearn.com/c4CcaO3nT71N/?ref=app

Answer 10

Proble! Woth entering a lower case pm

Answer 11

There are a lot of other cases to check 02:30pm, 02:30 pm, 2:30pm, 2:30 pm also with am

Answer 12

But such checks gives possibility to think in scope of writing production code. And such experience is very usefull in future

Answer 13

Yes it can be simplified. But i do not remember c function since i wrote on c++
you need just parse full str via scanf with 2 integer and 1 string param.

analyze am or pm(make upper the string and check on A or P) and make manipulation i thin +12 or -12 just math calculation need

Answer 14

Wow iam new to programing and I learnt a lot from your code sir😲 thank you very much ,.. I'll try to make my codes more efficient from now on😀 have a nice day ,... Happy coding 😁

Answer 15

Turns out I was just over complicating things 🤦🏻‍♂️ ,.. thanks for sharing this code 😊😊

Answer 16

Hima, good code, but you you have not some checks on correction!!!! As example is ok, but in comercial writing such code not aproved via qa department

Answer 17

So always try write codes with all possible check for future.

Answer 18

george what you really meant by "checks"? The code is meeting all the required conditions.

Answer 19

Hima enter the 12:30 without am and pm!!!!
enter 06:20 pm (small symbols) this checks need to be take to an account.

so in general code is good in all aspects if you enter correct AM/PM time, and for example,ot is great but in comercial writing such code will not be approved by QA department.

Answer 20

george Why should one do that in the first place ? The code is in accordance with the Input format and this is just wise thinking and making use of format specifiers at its best .