What sorting is wrong 🙄

Question

https://code.sololearn.com/ctB3LrnXm3qW/?ref=app

Iam try to input a array and I like to sort it ascending and descending orders

Sorting is mistake in my code . check and solve it guys

Answer 1

https://code.sololearn.com/cQ1Dsot10fBu/?ref=app

Answer 2

Provide more description of your question, give some sample input and the desired output to get more relevant answers.

Answer 3

Thank you very much

Answer 4

Okay 👌🆗

Answer 5

#include <bits/stdc++.h>
using namespace std;
int main()
{
int arr[10],c;
cout<<"Enter the number of elements in the array \n";
cin>>c;

int b = sizeof(arr);
cout<<"leanth off array= "<<b<<endl;
int q = sizeof(arr[0]);
cout<<q<<endl;
//(1) no need n thus n value

//int n = sizeof(arr) / sizeof(arr[0]); //sizeof (arr) is the total size occupied by the array. sizeof (arr [0]) is the size of the first element in the array.
cout<<"enter the every elements of the array orderly\n";

for(int i=0;i<c;i++)
{
cin>>arr[i];
}
cout<<"The array is\n";
for(int i=0;i<c;i++)
{
cout<<arr[i]<<" "<<"\n";
}
cout<<endl;

//(2)
// sort(arr,arr+n); n is total array size you declared as you calculated. you just need to use c as array elenents you are using.. so use
sort(arr,arr+c); //sorting the array from start to end.

//cond...

Answer 6

cout<<"Ascending order is \n";

for(int i=0;i<c;i++) //(3) array indexes starts from 0 so use, i=0 instead of 1 andd condition i<c;
{
cout<<arr[i]<<" ";
}
cout<<endl;

sort(arr,arr+c,greater<int>()); //(4)here same use c instead of n

cout<<"Descending order is \n";

for(int i=0;i<c;i++) //(5)same here use i=0 to c
{
cout<<arr[i]<<" ";
}
}

edit:

https://code.sololearn.com/cKASQ0bcX57b/?ref=app

Answer 7

you can remove n variable because unused.
And better to use
#include<iostream>
#include<algorithm>

In place of
#include <bits/stdc++.h>

You're welcome..

edit:
https://code.sololearn.com/cKASQ0bcX57b/?ref=app

Answer 8

Okay 👌

Answer 9

Look at this code for reference:
This is best for dynamically storing and sorting array.
plus it sorts floats and integral values
https://code.sololearn.com/cM95l02G31pX/?ref=app