Hi everyone in this code

Question

https://www.sololearn.com/en/compiler-playground/c3UUOFjodZDM
I have faced a problem I don't know why it says hour is not defined although I defined it as global variable

Answer 1

main() is requesting the hour and minute as parameters though they still have not been defined by convert(), since they are only defined there, note that convert() is only called inside main(), while it is running, main() is supposed to have its parameters filled at the start when running, before convert() gets called in its code, so this is a egg-chicken problem, try to remove the main() parameters and use the global variables created by convert() instead, that is, "hour" and "minute" instead of "h" and "m", if you prefer to use those variable names in main() simply create aliases by redefining the variables: "h, m = hour, minute", but in your code it isn't even necessary to do that, you don't need those global variables, just unpack the return values of convert() inside main(): "h, m = convert()"

Answer 2

Yusof ,

there are two reasons that make the code unnecessarily complicated.

> on the one hand it is the use of the main() function

> on the other hand it is the use of global variables.

i used your code and commented the unnecessary things. i turned the main() function into a completely normal code that is in the global scope.

see the code in the attached file.

https://sololearn.com/compiler-playground/cVPbD1WqV7vZ/?ref=app

Answer 3

In oder you to modify any global state in a function
1. You need to define it at top level
2. You need the global keyword defined inside the function

Answer 4

any reason you done that way ? Instead of passing it directly?

Answer 5

I make the code simpler and working check this

https://www.sololearn.com/en/compiler-playground/czfk3DDXPav8

Answer 6

ThanksLothar but this code is a solution of problem set from cs50 course it is required to use two functions main and convert

Answer 7

This way it works:

def convert(time):
hour,minute=time.split(":")
hour=int(hour)
minute=int(minute)
return hour,minute

def main():
tim=input("Enter time: ")
h, m = convert(tim)
if h in range(7,9):
if m in range(0,60):
print("breakfast time")
elif h in range(12,14):
if m in range(0,60):
print("lunch time")
elif h in range(18,20):
if m in range(0,60):
print("dinner time")

main()

It is good practique to define the main() function as the last function and its utilities before