Any tips or advice on c++ password generator

Question

Hiya All.
I have created a small password generator (yeah I know, plenty here already) and was after some advice on how to make it better.

I have linked the code below
https://code.sololearn.com/cFxdiCUu5OG2/?ref=app

Answer 1

Divide the characters in 2 groups: vowel-like and consonant type. For example, vowels = {0, o, O, 4, a, A...} and consonats = {$, s, S, 6, g, G...}. Now, create a password of 8-10 characters alternating random vowels and consonants, starting from a random type. This way, it will be easy to "pronounce" the world and remember the password.

Answer 2

this needs a multiple best answer feature.. 😀 thanks!

Answer 3

updated.yeah i am slow... shhhh

better?

https://code.sololearn.com/cFxdiCUu5OG2/?ref=app

Answer 4

ok! clarification: do you mean random vowel or consonant each letter?

such as if last letter was a vowel there is x% chance that the next letter wont be type of deal?

Answer 5

Make it that user could choose symbols that he wants to see or to avoid in password. Maybe selection desired groups or something similar. Also you can add "easy" password generation option that will make passwords be composed of syllables and looking like generated words that is easy to memorise.

Answer 6

Nice one, now you can try to improve generating algorithm so it not generate symbols always in same repeating order (consonant-vowel).

Answer 7

I mean that you can implement some more forms of syllables, not only "ab" but also "ba" or "abb" and "baa" for example. And set frequncy of generation for it. It will make your passwords less predictable and harder to bruteforce.