Look this c++ code.

Question

https://code.sololearn.com/cVAE0HBy6QJg/?ref=app
It's working properly till 12! but after that it's not. Why? As per me there is no logical error in it. if you find one, please tell.

Answer 1

@Rame

you have to increase memory size of your variable and not function.

keep int function()
change unsigned long long int y;

Answer 2

no don't change function datatype, it won't have any affect.
you need to increase storage memory of int variable by using,

unsigned long long int y;
where y is your variable storing value of factorial.

Answer 3

@rame
i am not really sure about that, but you can try both cases.

Answer 4

You hit the maximum value int can store. Replace 'int' with 'long long' and it will go further. However, you will hit that maximum after a few more numbers.

Answer 5

There must be some corrections in your code
https://code.sololearn.com/cmPHgzp3RAnV/?ref=app

Answer 6

@john wells #include <iostream>
using namespace std;

long long fact(long long x) {
long long y,i,prod=1;
cin>>y;
for(i=1;i<=y;i++)
{
prod*=i;
}
return prod;
}

int main()
{
long long y;
cout<<fact(y);
return 0;
}

is this correct?

Answer 7

Please check it.

Answer 8

@infinity The code you posted is public?
I guess you forgot to do so.

Answer 9

@dhruv garg
do i need to change my Function datatype even when I use use recursion( like one I used in my program) ?