Does anyone know what a major flaw Is

Question

The code compiles and it runs perfectly but they say it contains a major flaw so i want to know what is a flaw exactly

Answer 1

Flaw (Noun):
a mistake or shortcoming in a plan, theory, or legal document that causes it to fail or reduces its effectiveness.

Basically, they're saying that your syntax and such may be fine, but the logical design or similar is flawed, so you'll run into issues on that end of it. For example, lets say I created a box and it works exactly like a box works; you can open it, put things in it, close it, carry it, etc... However, lets say the purpose of my box is to store an animal inside of it. Sure, I created a box and it works perfectly as a box does, but a major flaw of my box is that I didn't think to put in holes for air so that the animal could breathe.

What code of yours is in question? If you post it up, I'd be more than happy to look at it to see if I can see what they're talking about, then I can provide you with feedback for improvement.

Did they tell you what the major flaw was or give you any useful information toward this? Also, did you ask them for more specifics on the issue so you could learn from their feedback?

Answer 2

https://code.sololearn.com/cfpxpht39Y87/?ref=app

This is the code that they gave us

can you find the flaw in this code