Where did I go wrong?

Question

window.onload = function() {
setInterval(showTime, 1000);
changeBodyColor();
}
function showTime() {
var d = new Date();
var hours = d.getHours();
var minutes = d.getMinutes();
var seconds = d.getSeconds(); document.getElementById("time").innerHTML = hours + ":" + minutes + ":" + seconds;
}
function bbgcolo(){
var s = new Date();
var secs = s.getSeconds();
if(secs % 2 === 0){
document.body.style.backgroundColor.innerHTML = "white";
} else {
document.body.style.backgroundColor.innerHTML = "black";
}
}

I want to change the background color of the page but script isn't working..

Problem solved!! Thanks Thanks Thanks if you had intention of helping me.. But for now, I am closing this case.. If you have better ideas, please share!!
https://code.sololearn.com/WcIpzGt2vy6V/?ref=app
visit this 👆👆👆

Answer 1

This is wrong:
document.body.style.backgroundColor.innerHTML = "white";

This is right:
document.body.style.backgroundColor = "white";

Similar applies to setting "black" obviously.

innerHTML is for HTML elements. It isn't for CSS properties.

Answer 2

To fix everything, you could do this. I made minimal changes so you could learn from them:

window.onload = function() {
setInterval(showTime, 1000);
}

function showTime() {
var d = new Date();
var hours = d.getHours();
var minutes = d.getMinutes();
var seconds = d.getSeconds();
document.getElementById("time").innerHTML = hours + ":" + minutes + ":" + seconds;
bbgcolo();
}

function bbgcolo() {
var s = new Date();
var secs = s.getSeconds();
if(secs % 2 === 0){
document.body.style.backgroundColor = "white";
} else {
document.body.style.backgroundColor = "black";
}
}

Answer 3

Edited code:-
https://code.sololearn.com/WLVTQSp08b9V/?ref=app

Answer 4

Mohammad Mehedi Hasan provide correct url of images

Answer 5

https://code.sololearn.com/WNZsEv7ZNU01/?ref=app

Answer 6

Mohammad Mehedi Hasan for increment in i
So, i am declare 'i' outside the function

Answer 7

Edited code:-
https://code.sololearn.com/WLVTQSp08b9V/?ref=app

Answer 8

Mohammad Mehedi Hasan share you code link

Answer 9

Mohammad Mehedi Hasan i think you want images changed by according time

Answer 10

window.onload = function() {
setInterval(showTime, 1000);
}
function showTime() {
var d = new Date();
var hours = d.getHours();
var minutes = d.getMinutes();
var seconds = d.getSeconds(); document.getElementById("time").innerHTML = hours + ":" + minutes + ":" + seconds;
if(seconds % 2 == 0){
document.body.style.backgroundColor = "white";
} else {
document.body.style.backgroundColor = "black";
}
var images = ["images.jpeg", "images (1).jpeg", "images (2).jpeg", "images (3).jpeg", "images (4).jpeg"];
for(var i=0; i<images.length; i++) {
document.getElementById("imges").src.innerHTML = images[i];
if(i > images.length) {
i =0;
}
}
}

Why the images aren't appearing?

Answer 11

urls are correct.. I had put one of them inside src tag in html file

Answer 12

https://code.sololearn.com/W00jB0xLzsh0/?ref=app

Answer 13

umm.. yeah

Answer 14

can you please explain what it does?

Answer 15

Exams why I need to declare the variable i .. outside of the function showTime

Answer 16

Ayush Mishra, did you just copy/paste my answer? It is word for word exactly the same as what I typed.

Answer 17

This adjusts text colour to be the opposite of the background colour.
I also adjusted the background to be black when the second is even like you asked.

window.onload = function() {
setInterval(showTime, 1000);
}

function showTime() {
var d = new Date();
var hours = d.getHours();
var minutes = d.getMinutes();
var seconds = d.getSeconds();
document.getElementById("time").innerHTML = hours + ":" + minutes + ":" + seconds;
bbgcolo();
}

function bbgcolo() {
var s = new Date();
var secs = s.getSeconds();
if(secs % 2 === 1){
document.body.style.backgroundColor = "white";
document.body.style.color = "black";
} else {
document.body.style.backgroundColor = "black";
document.body.style.color = "white";
}
}

Regarding the images problem, you should create a new question to tackle that after this background colour and text colour problem. It is harder to follow discussions about many diverging topics than stick to a single question. Also, share an example on Sololearn's Code Playground. https://code.sololearn.com/W00jB0xLzsh0/?ref=app is a broken link.

Answer 18

Problem solved!! Thanks Thanks Thanks if you had intention of helping me.. But for now, I am closing this case.. If you have better ideas, please share!!
https://code.sololearn.com/WcIpzGt2vy6V/?ref=app
visit this 👆👆👆

Answer 19

You first need to make sure that the text colour of element #time can be visible over a black/white background colour

window.onload = function()
{
setInterval( showTime, 1000 );
}

function showTime()
{
var d = new Date();
document.getElementById("time").innerHTML = d.getHours() + ":" + d.getMinutes() + ":" + d.getSeconds();
var bgColour = "white";
if( d.getSeconds() % 2 == 0 )
{
bgColour = "black";
}
document.body.style.backgroundColor = bgColour;
}

Answer 20

This is wrong:
document.body.style.backgroundColor.innerHTML = "white";

This is right:
document.body.style.backgroundColor = "white";

Similar applies to setting "black" obviously.

innerHTML is for HTML elements. It isn't for CSS properties.