collatz sequence it says error in line 2 i.e try:

Question

help to complete the collatz sequence

def Collatz(number):
try:
if number%2==0:
print(number//2)
return(number//2)
elif number%2==1:
print(3*number+1)
return(3*number+1)
except valueError:
print('number entered is invalid')

number=int(input('enter any number'))

while number >1:
print(collatz(number))

Answer 1

There is just 2 minor error in your code.... first blocks are properly indent and second name of the function at function call. check this out

def Collatz(number):
try:
if number%2==0:
print(number//2)
return(number//2)
elif number%2==1:
print(3*number+1)
return(3*number+1)
except valueError:
print('number entered is invalid')

number=int(input('enter any number'))

while number >1:
print(Collatz(number))

Answer 2

Everything is fine just minor change in the condition of While loop. Just copy below code and run it you will get your desired sequence

def Collatz(number):
try:
if number%2==0:
print(number//2)
return(number//2)
elif number%2==1:
print(3*number+1)
return(3*number+1)
except valueError:
print('number entered is invalid')

number=int(input('enter any number'))

while number != 1:
number = Collatz(number)

Answer 3

You should indent the try and except blocks. Also standard indentation is 4 spaces/tab.

Answer 4

Yh, you should indent after function definition

Answer 5

You should indent the try and except blocks after function definition.

Answer 6

guys it still does not work properly......it goes in to infinite loop

Answer 7

thanks Waqas and all guys...basically the problem was in last line