What is wrong here

Question

for(i; i!=0; i=i){

if((i%p)==0){
cout<<p<<"×";
i=i/p;

}

else {p++;}

Answer 1

Well it's showing odd results.

https://code.sololearn.com/c8J4dzZZfr1L/?ref=app

I might have your code's logic. The mistake that you made was to put an else() statement outside of the {} braces of the for() loop.

updated code:

for(i; i!=0; i=i){

if((i%p)==0){
cout<<p<<"×";
i=i/p;

else {p++;}
}

Answer 2

/*this is the whole code.
I made some changes.
now it works, Thanks.*\

#include<iostream>
#include<math.h>

using namespace std;

int main(){

int i,p=2,n=0,c;
cout<<"numero para extraer descomposicion factorial: ";cin>>i;
c=i;
while(i!=1){
n=i%p;
if(n==0){
cout<<p<<"×";
i=i/p;
}
else {p++;}
}
cout<<"1= "<<c;
return 0;
}