Problem with my code it’s crashing if the index less than the reminder of the days left.

Question

My code worked find if I test it with Monday and increment it by two. It returns Wednesday. But if it’s Friday and increment it by four it throws an error out of range.
https://code.sololearn.com/ciK6mNroq4br/?ref=app

Answer 1

I'll post a snipet of the part that I edited:
if (it != daysOfTheWeek.end()) {
int incrementIndex = std::stoi(increment);
return daysOfTheWeek[(std::distance(daysOfTheWeek.begin(),it) + incrementIndex)%7];
}

Answer 2

When you add incrementIndex to the iterator, the result can be larger than the size of the vector.
You'll want to % 7 the result before you access the vector.

There is no need to use % 7 on the previous line then because the new one will take care of it too.

Also 'it - daysOfTheWeek.begin()' can be replaced with 'std::distance( daysOfTheWeek.begin(), it )'.

Answer 3

Here it works here
https://code.sololearn.com/c4198l54hJFS/?ref=app

Answer 4

Dennis wait i tried to do it your way it crashed my whole program

Answer 5

Can you post your updated code? When I make the change it works fine.

Answer 6

Dennis so with yours if you test Friday and 4 the Result tuesday?

Answer 7

Yes

Answer 8

Dennis i did what you said exactly. Can j see your version cause mine would be a hustle to upload to here

Answer 9

Dennis i see my mistake.